Current state of key bindings

Apr 1, 2010 at 1:58 AM
Edited Apr 1, 2010 at 3:52 AM

I posted something here earlier that I had to edit out since after much closer inspection of the code I realized my initial impression was wrong.

I think implementing hot keys could be something I'm up to, provided I won't be duplicating anyone else's efforts. Is anyone actively working on this feature?

Developer
Apr 1, 2010 at 3:33 PM

I haven't look to much into hotkeys as it appeared Brian had plans for addressing them and started working on it (my hope was that he'd get back involved, but that might not happen, at least not soon).

Apr 1, 2010 at 6:13 PM

Ok, I'll start working on it and if something good comes out of it I'll send you a patch. It seems like Brian already paved most of the way for the feature.

Apr 9, 2010 at 1:19 PM

Seems like doing the Key bindings overhaul is going to be a lot of work (maybe even more work than it's worth). After doing some light brainstorming I realized that the only complaint about keybindings that I've heard of (which is also a complaint of mine) is not being able to remap the "Show Cropform" key. Seems some debuggers and apps use F8 for their own purposes and Cropper is either not getting the key or not letting the application get it.

What I propose is, why not stick to YAGNI and implement changing that one key mapping? This would make it a lot simpler to implement and it will actually make more sense to implement instead of a bunch of actions that need to be mapped and managed both globally/locally on both the parent forms and the layered form.

I'll work on it and send a patch so you can tell me what you think.

Jun 24, 2010 at 5:05 PM
I love Cropper, but can't use it because it hijacks the F8 key. I made a slight code change to use Ctrl-PrtScn to toggle the crop window visibility, instead of F8. I can submit a patch, if you'd like.
Jul 28, 2010 at 1:57 PM
Please send me the patch. I also cant use it because of F8.
Sep 1, 2010 at 9:34 PM

Could I also get the patch?

Jan 11, 2011 at 6:59 PM

Running 1.9.4.89, is the patch still available to get please.

Jan 11, 2011 at 7:12 PM

Here's the patch:

http://dl.dropbox.com/u/17007033/Ctrl-PrtScn.patch

I've also submitted it to the project for inclusion.

Jan 12, 2011 at 1:57 PM

I feel real stupid but how do you install the patch?

Jan 12, 2011 at 2:24 PM

Don't feel stupid, it's a source code patch created with Subversion.  It's meant for developers.  You can download the Cropper source code, apply the patch, and recompile.  The developers of this project should take care of it and release a new version.

Jan 12, 2011 at 7:42 PM
Edited Jan 12, 2011 at 8:12 PM

Thanks! I'm an out-of-practice developer (now in technical consulting rather than writing code) so setting up a dev environment and building isn't worth the time.

If anyone just happens  to have a built .exe with the patch... :) Otherwise I'll monitor the site.

May 3, 2011 at 5:07 AM

I submitted a patch that adds this functionality as an option to the user. In the meantime, if anyone wants to play with it, I have made an installer with that change included: https://github.com/downloads/enriquein/Cropper/CropperSetup-1.9.4-p2.zip

I have a fork of this repository over at github where I'll be more than glad to accept patches or pull requests while the original cropper team can evaluate these patches and incorporate them into Cropper properly. My github repo is here: https://github.com/enriquein/Cropper

May 3, 2011 at 2:51 PM
Hey, nice job! Thank you very much.

A suggestion: The checkbox "Ctrl+PrintScreen shows crop form (Requires Restart) is unclear, because there is no indication that F8 is the default. May I suggest that you use radio buttons:

Show Cropper form (requires restart):
(*) F8 ( ) Ctrl+PrintScreen

Cheers,

--Franklin

On Tue, May 3, 2011 at 12:07 AM, enriquein <notifications@codeplex.com> wrote:

From: enriquein

I submitted a patch that adds this functionality as an option to the user. In the meantime, if anyone wants to play with it, I have made an installer with that change included: https://github.com/downloads/enriquein/Cropper/CropperSetup-1.9.4-p2.zip

I have a fork of this repository over at github where I'll be more than glad to accept patches or pull requests while the original cropper team can evaluate these patches and incorporate them into Cropper properly. My github repo is here: https://github.com/enriquein/Cropper

Read the full discussion online.

To add a post to this discussion, reply to this email (cropper@discussions.codeplex.com)

To start a new discussion for this project, email cropper@discussions.codeplex.com

You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe on CodePlex.com.

Please note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at CodePlex.com




--
Franklin Davis
+1 857-241-7131
franklin.davis@gmail.com
Skype fdavis99
http://www.linkedin.com/in/franklindavis

May 3, 2011 at 3:52 PM
Great suggestion, I'll look into it tonight.

----------------------------------
Enrique Ramirez
Lead developer

On May 3, 2011, at 9:52 AM, "fdavis99"<notifications@codeplex.com> wrote:

From: fdavis99

Hey, nice job! Thank you very much.

A suggestion: The checkbox "Ctrl+PrintScreen shows crop form (Requires Restart) is unclear, because there is no indication that F8 is the default. May I suggest that you use radio buttons:

Show Cropper form (requires restart):
(*) F8 ( ) Ctrl+PrintScreen

Cheers,

--Franklin

On Tue, May 3, 2011 at 12:07 AM, enriquein <notifications@codeplex.com> wrote:

From: enriquein

I submitted a patch that adds this functionality as an option to the user. In the meantime, if anyone wants to play with it, I have made an installer with that change included: https://github.com/downloads/enriquein/Cropper/CropperSetup-1.9.4-p2.zip

I have a fork of this repository over at github where I'll be more than glad to accept patches or pull requests while the original cropper team can evaluate these patches and incorporate them into Cropper properly. My github repo is here: https://github.com/enriquein/Cropper

Read the full discussion online.

To add a post to this discussion, reply to this email (cropper@discussions.codeplex.com)

To start a new discussion for this project, email cropper@discussions.codeplex.com

You are receiving this email because you subscribed to this discussion on CodePlex. You can unsubscribe on CodePlex.com.

Please note: Images and attachments will be removed from emails. Any posts to this discussion will also be available online at CodePlex.com




--
Franklin Davis
+1 857-241-7131
franklin.davis@gmail.com
Skype fdavis99
http://www.linkedin.com/in/franklindavis